From a92c45237842c588e67d5757cbd663505b503f44 Mon Sep 17 00:00:00 2001 From: Ben Lickly Date: Thu, 5 Dec 2019 14:20:41 -0800 Subject: [PATCH 1/2] Mark as `const` a non-mutable export --- tfjs-core/src/engine.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tfjs-core/src/engine.ts b/tfjs-core/src/engine.ts index 594c8ce9a89..da81c7b6e67 100644 --- a/tfjs-core/src/engine.ts +++ b/tfjs-core/src/engine.ts @@ -1102,4 +1102,4 @@ function getOrMakeEngine(): Engine { return ns._tfengine; } -export let ENGINE = getOrMakeEngine(); +export const ENGINE = getOrMakeEngine(); From f943e1182326a614cda86703267e65cdde102b26 Mon Sep 17 00:00:00 2001 From: Ben Lickly Date: Thu, 5 Dec 2019 14:21:10 -0800 Subject: [PATCH 2/2] Make a mutable export immutable --- tfjs-core/src/jasmine_util.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tfjs-core/src/jasmine_util.ts b/tfjs-core/src/jasmine_util.ts index 4a84d8b44bb..2ed8a0f1c02 100644 --- a/tfjs-core/src/jasmine_util.ts +++ b/tfjs-core/src/jasmine_util.ts @@ -210,7 +210,7 @@ export interface TestEnv { isDataSync?: boolean; } -export let TEST_ENVS: TestEnv[] = []; +export const TEST_ENVS: TestEnv[] = []; // Whether a call to setTestEnvs has been called so we turn off // registration. This allows command line overriding or programmatic @@ -218,7 +218,8 @@ export let TEST_ENVS: TestEnv[] = []; let testEnvSet = false; export function setTestEnvs(testEnvs: TestEnv[]) { testEnvSet = true; - TEST_ENVS = testEnvs; + TEST_ENVS.length = 0; + TEST_ENVS.push(...testEnvs); } export function registerTestEnv(testEnv: TestEnv) {