From 932f33dd3baf4963125d03c89b8a5bb656f501b6 Mon Sep 17 00:00:00 2001
From: Ping Yu <4018+pyu10055@users.noreply.github.com>
Date: Fri, 13 Dec 2019 13:56:04 -0800
Subject: [PATCH 1/3] fix cloud function error and updated readme

---
 tfjs-converter/cloudbuild_nightly.yml        | 2 --
 tfjs-converter/scripts/cloud_funcs/README.md | 2 +-
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/tfjs-converter/cloudbuild_nightly.yml b/tfjs-converter/cloudbuild_nightly.yml
index b9c0357ece7..501c0e47a6e 100644
--- a/tfjs-converter/cloudbuild_nightly.yml
+++ b/tfjs-converter/cloudbuild_nightly.yml
@@ -23,8 +23,6 @@ steps:
 
 secrets:
 - kmsKeyName: projects/learnjs-174218/locations/global/keyRings/tfjs/cryptoKeys/enc
-  secretEnv:
-    BROWSERSTACK_KEY: CiQAkwyoIW0LcnxymzotLwaH4udVTQFBEN4AEA5CA+a3+yflL2ASPQAD8BdZnGARf78MhH5T9rQqyz9HNODwVjVIj64CTkFlUCGrP1B2HX9LXHWHLmtKutEGTeFFX9XhuBzNExA=
 timeout: 1800s
 logsBucket: 'gs://tfjs-build-logs'
 substitutions:
diff --git a/tfjs-converter/scripts/cloud_funcs/README.md b/tfjs-converter/scripts/cloud_funcs/README.md
index ab840bc3d69..eac4b912941 100644
--- a/tfjs-converter/scripts/cloud_funcs/README.md
+++ b/tfjs-converter/scripts/cloud_funcs/README.md
@@ -8,7 +8,7 @@ Command to re-deploy:
 ```sh
 gcloud functions deploy converter_pip_nightly_test \
   --runtime nodejs8 \
-  --trigger-topic nightly
+  --trigger-topic converter_python_nightly
 ```
 
 ### The pipeline

From 8f1257d783a6c0371e50097b0c4fa1290a928d38 Mon Sep 17 00:00:00 2001
From: Ping Yu <4018+pyu10055@users.noreply.github.com>
Date: Fri, 13 Dec 2019 14:06:03 -0800
Subject: [PATCH 2/3] updated readme

---
 tfjs-converter/scripts/cloud_funcs/README.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tfjs-converter/scripts/cloud_funcs/README.md b/tfjs-converter/scripts/cloud_funcs/README.md
index eac4b912941..d17ac4deb0a 100644
--- a/tfjs-converter/scripts/cloud_funcs/README.md
+++ b/tfjs-converter/scripts/cloud_funcs/README.md
@@ -6,7 +6,7 @@ You can also trigger the function manually via the Cloud UI.
 
 Command to re-deploy:
 ```sh
-gcloud functions deploy converter_pip_nightly_test \
+gcloud functions deploy converter_python_nightly \
   --runtime nodejs8 \
   --trigger-topic converter_python_nightly
 ```

From f2f136fe4959d41f37b4a1a9f861f665aeffa88f Mon Sep 17 00:00:00 2001
From: Ping Yu <4018+pyu10055@users.noreply.github.com>
Date: Fri, 13 Dec 2019 14:21:28 -0800
Subject: [PATCH 3/3] remove the secret field

---
 tfjs-converter/cloudbuild_nightly.yml | 2 --
 1 file changed, 2 deletions(-)

diff --git a/tfjs-converter/cloudbuild_nightly.yml b/tfjs-converter/cloudbuild_nightly.yml
index 501c0e47a6e..215ba60d405 100644
--- a/tfjs-converter/cloudbuild_nightly.yml
+++ b/tfjs-converter/cloudbuild_nightly.yml
@@ -21,8 +21,6 @@ steps:
   args: ['./build-pip-package.sh', '--test-nightly', '/tmp/tfjs-pips']
   waitFor: ['yarn']
 
-secrets:
-- kmsKeyName: projects/learnjs-174218/locations/global/keyRings/tfjs/cryptoKeys/enc
 timeout: 1800s
 logsBucket: 'gs://tfjs-build-logs'
 substitutions: