Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update karma version to remove Security vulnerability #3067

Closed
wants to merge 10 commits into from

Conversation

kangyizhang
Copy link
Contributor

@kangyizhang kangyizhang commented Apr 10, 2020

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.


This change is Reviewable

@nsthorat
Copy link
Contributor

I think you need to update babel for karma-typescript as well:

https://pantheon.corp.google.com/cloud-build/builds/26f0e129-cf82-4dfc-8179-9c0c46fab8c2;step=2?project=learnjs-174218

10 04 2020 23:50:23.963:ERROR [transformer.karma-typescript]: /workspace/tfjs-vis/node_modules/vega-embed/build/vega-embed.js: Cannot find module 'babel-preset-env' from '/workspace/tfjs-vis'
- Did you mean "@babel/env"?

Copy link
Contributor

@nsthorat nsthorat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 22 of 22 files at r1.
Reviewable status: :shipit: complete! 2 of 1 approvals obtained (waiting on @dsmilkov, @nsthorat, and @tafsiri)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants