[core] Support explicit padding in tf.conv. #3427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annxingyuan
requested review from
lina128 and
tafsiri
and removed request for
lina128 and
tafsiri
pyu10055
approved these changes
Jun 12, 2020
Collaborator
pyu10055
left a comment
pyu10055
left a comment
There was a problem hiding this comment.
Reviewed 12 of 12 files at r1.
Reviewable status:complete! 1 of 1 approvals obtained (waiting on @annxingyuan and @pyu10055)
tfjs-core/src/ops/conv_util.ts, line 22 at r1 (raw file):
type PadType = 'SAME'|'VALID'|'NUMBER'|'EXPLICIT'; // For NHWC should be in the following form:
Is the case that we only support NHWC format not the NCHW?
annxingyuan
commented
Jun 12, 2020
Contributor
Author
annxingyuan
left a comment
annxingyuan
left a comment
There was a problem hiding this comment.
Reviewable status:
tfjs-core/src/ops/conv_util.ts, line 22 at r1 (raw file):
Previously, pyu10055 (Ping Yu) wrote…
Is the case that we only support NHWC format not the NCHW?
Ah, thanks for catching that. I looked at the validation logic for conv1d and assumed we only allowed NHWC, but in conv2d we allow NCHW. I've added support for NCHW explicit padding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #3311
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is