Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate examples and documentation to TF core #59

Closed
amygdala opened this issue May 16, 2018 · 5 comments
Closed

Migrate examples and documentation to TF core #59

amygdala opened this issue May 16, 2018 · 5 comments
Assignees

Comments

@amygdala
Copy link

amygdala commented May 16, 2018

Is there some reason these examples are still using tf.contrib.learn?
e.g. https://github.com/tensorflow/transform/blob/master/examples/census_example.py#L31

(seems like that's not going to help demystify tft for users..)

Update: similarly re: mentions of "tf.Learn" in the docs, e.g. here: https://github.com/tensorflow/transform/blob/master/getting_started.md
I think this will just confuse people.

@elmer-garduno
Copy link
Contributor

elmer-garduno commented May 17, 2018

Thanks @amygdala great point, I'll update the issue name and we'll work on migrating the examples to TF core.

@elmer-garduno elmer-garduno changed the title Is there some reason these examples are using tf.contrib.learn? Migrate examples and documentation to TF core May 17, 2018
@elmer-garduno elmer-garduno self-assigned this May 17, 2018
@amygdala
Copy link
Author

oh great, thanks!

@amygdala
Copy link
Author

Update: okay, I might just put in a PR for this instead... as I mentioned to Elmer, I did the conversion for the sentiment one for my own purposes and it would be straightforward to just do the rest of it.

@elmer-garduno
Copy link
Contributor

Thanks Amy, a PR will be very welcome.

@KesterTong
Copy link
Contributor

Examples are now using core

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants