tl.iterate.minibatch support list with shuffle #474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgarithm
reviewed
Apr 8, 2018
| else: | ||
| excerpt = slice(start_idx, start_idx + batch_size) | ||
| yield inputs[excerpt], targets[excerpt] | ||
| if (isinstance(inputs, list) or isinstance(targets, list)) and (shuffle == True): |
Member
There was a problem hiding this comment.
does it still work if isinstance(inputs, list) == True but isinstance(targets, list) == False?
Member
Author
There was a problem hiding this comment.
nope, it doesn't, list can't be indexed by a list of ID.
Member
There was a problem hiding this comment.
inputs = [inputs[i] for i in excerpt] if isinstance(inputs, list) else inputs[excerpt]
targets = [targets[i] for i in excerpt] if isinstance(targets, list)) else targets[excerpt]
yield inputs, targets
wagamamaz
approved these changes
Apr 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This API works well for numpy array input, but when inputs are list, and we shuffle the data, we can't index the elements in a list with a list.