Skip to content

Server still sending notifications if app is unauthorized #61

Closed
ePirat opened this Issue Dec 28, 2012 · 6 comments

3 participants

@ePirat
ePirat commented Dec 28, 2012

When I unauthorize an app, in some cases the server seems to still send POST's for notifications to the tent_notification_url the app has set.
(Happened with tent.is server for ^marco.tent.is)

@ePirat
ePirat commented Dec 28, 2012

This might be tent.is related… I've observed receiving notifications twice for some posts too…

@titanous
Tent — the protocol for decentralized communication member

Yeah, there may have been webhooks that were queued before the app was unauthorized. Do you continue to receive notifications?

Duplicate notifications should be dealt with gracefully, there is no guarantee that a notification will only be delivered once.

@ePirat
ePirat commented Dec 28, 2012

I am still receiving them.

@jvatic jvatic pushed a commit that closed this issue Dec 28, 2012
Jesse Stuart Fix: Deleting app/app authorization
- delete app_authorizations when deleteing app
- delete notification_subscriptinos when deleting app authorization

fixes #61
27925c0
@jvatic jvatic closed this in 27925c0 Dec 28, 2012
@jvatic jvatic reopened this Dec 28, 2012
@jvatic
Tent — the protocol for decentralized communication member
jvatic commented Dec 28, 2012

I'll need some more information in order to debug this further—either the app id or tent_notification_url.

I thought this must be due to a subscription sticking around after the authorization was deleted, but there don't appear to be any orphans in the database; And the subscription model doesn't send the notification if it's orphaned.

@ePirat
@jvatic
Tent — the protocol for decentralized communication member
jvatic commented Dec 28, 2012

Found and deleted the orphaned authorization; Your app shouldn't be receiving any more notifications from it and 27925c0 will prevent this from happening again.

@jvatic jvatic closed this Dec 28, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.