Skip to content

Make port-encoding for Arrow host-independent #1007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 6, 2020
Merged

Make port-encoding for Arrow host-independent #1007

merged 1 commit into from
Aug 6, 2020

Conversation

dominiklohmann
Copy link
Member

No description provided.

@dominiklohmann dominiklohmann added the bug Incorrect behavior label Aug 6, 2020
@dominiklohmann dominiklohmann requested a review from a team August 6, 2020 12:59
@dominiklohmann dominiklohmann force-pushed the story/ch18677/arrow-port-encoding branch from 3f6e5ef to a151ab4 Compare August 6, 2020 13:01
mavam
mavam requested changes Aug 6, 2020
View reviewed changes
Copy link
Member

@mavam mavam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we actually want something slightly different: encode the port as Struct<UInt16, UInt8> in Arrow.

@dominiklohmann dominiklohmann force-pushed the story/ch18677/arrow-port-encoding branch from 577c92c to 8e811e1 Compare August 6, 2020 13:49
@dominiklohmann dominiklohmann force-pushed the story/ch18677/arrow-port-encoding branch from 8e811e1 to 5829e28 Compare August 6, 2020 14:20
@dominiklohmann
Copy link
Member Author

dominiklohmann commented Aug 6, 2020 •
edited
Loading

I think we actually want something slightly different: encode the port as Struct<UInt16, UInt8> in Arrow.

We discussed in the office that this is not possible with the current column_builder_trait, as it requires state. There is no such thing as a StructBuilder that is templated to its members; instead, the StructBuilder receives the builders for its fields during construction, i.e., at runtime.

@dominiklohmann dominiklohmann merged commit 2438c3c into master Aug 6, 2020
@dominiklohmann dominiklohmann deleted the story/ch18677/arrow-port-encoding branch August 6, 2020 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mavam mavam mavam approved these changes

Assignees
No one assigned
Labels
bug Incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dominiklohmann @mavam