Skip to content

Always convert JSON null to VAST nil #1009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 7, 2020
Merged

Always convert JSON null to VAST nil #1009

merged 3 commits into from
Aug 7, 2020

Conversation

dominiklohmann
Copy link
Member

Additionally, this bug fix contains an extension to the Suricata schema contriubuted by @satta.

@dominiklohmann dominiklohmann added enhancement ✨ bug Incorrect behavior labels Aug 7, 2020
@dominiklohmann dominiklohmann requested a review from a team August 7, 2020 07:30
tobim
tobim approved these changes Aug 7, 2020
View reviewed changes
Copy link
Member

@tobim tobim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the problem, thanks for taking care of it!

@dominiklohmann dominiklohmann merged commit 9b8e52b into master Aug 7, 2020
@dominiklohmann dominiklohmann deleted the topic/suricata-ftp branch August 7, 2020 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobim tobim tobim approved these changes

Assignees
No one assigned
Labels
bug Incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dominiklohmann @tobim