Rename vector to list #1016
Rename vector to list #1016
Conversation
| @@ -45,7 +45,7 @@ struct fixture { | |||
| } | |||
|
|
|||
| type t; | |||
| vector r; | |||
| std::vector<data> r; | |||
There was a problem hiding this comment.
| std::vector<data> r; | |
| list r; |
There was a problem hiding this comment.
See my comment below for why going with std::vector<data>.
| @@ -55,7 +55,7 @@ FIXTURE_SCOPE(event_tests, fixture) | |||
|
|
|||
| TEST(basics) { | |||
| CHECK_EQUAL(e.type().name(), "foo"); | |||
| REQUIRE(caf::holds_alternative<vector>(e.data())); | |||
| REQUIRE(caf::holds_alternative<std::vector<data>>(e.data())); | |||
There was a problem hiding this comment.
| REQUIRE(caf::holds_alternative<std::vector<data>>(e.data())); | |
| REQUIRE(caf::holds_alternative<list>(e.data())); |
There was a problem hiding this comment.
Here, list is the wrong way to think about this. An event is a sequence of data, not an instance of list. This is why I changed it to std::vector<data>. It'll change with the record change in data as well.
There was a problem hiding this comment.
I think this is just unnecessarily confusing. A list now is exactly a sequence of data, because that is quite literally its definition.
There was a problem hiding this comment.
Yes, but it's a value for a single field. Here, we are modeling a sequence of values, each of which represent a single field.
There was a problem hiding this comment.
I still disagree with you, but not not enough to argue about this one.
There was a problem hiding this comment.
Fair enough, it'll change soon anyway once record is there.
No description provided.