Close file descriptor by default in 'vast::file' #1018
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the default behaviour of `vast::file` so that the associated file descriptor is closed by default. This is closer to the behaviour of standard library classes, and less surprising to developers who expect a RAII by default.
tobim
reviewed
Aug 10, 2020
dominiklohmann
requested changes
Aug 10, 2020
Remove the 'close_on_destruction_' member and the corresponding constructor setting it from vast::file since there was no code using this functionality.
dominiklohmann
approved these changes
Aug 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change to "not close by default" was introduced in this commit, I'm not sure if it was intentional or just an oversight.