Don't overwrite index state after startup error #1026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't overwrite the on-disk state if we fail to restore it, since the newly written state will surely be empty and overwrite the existing VAST data on disk.
|
I think this warrants a changelog entry, doesn't it? |
dominiklohmann
approved these changes
Aug 24, 2020
mavam
previously requested changes
Aug 24, 2020
lava
force-pushed
the
topic/index-flush-shutdown
branch
from
f04719f to
1058ae8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't overwrite the on-disk state if we fail to restore it, since
the newly written state will surely be empty and overwrite the
existing VAST data on disk.