Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make periodic logging more sensible #1035

Merged
merged 5 commits into from
Sep 1, 2020
Merged

Make periodic logging more sensible #1035

merged 5 commits into from
Sep 1, 2020

Conversation

tobim
Copy link
Member

@tobim tobim commented Sep 1, 2020

No description provided.

@tobim tobim added the maintenance Tasks for keeping up the infrastructure label Sep 1, 2020
@tobim tobim requested a review from a team September 1, 2020 09:43
dominiklohmann
dominiklohmann requested changes Sep 1, 2020
View reviewed changes
Copy link
Member

@dominiklohmann dominiklohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nits.

What about the index log message counterpart to the archive? Should we move it to debug, too?

tobim and others added 2 commits September 1, 2020 12:37
@tobim @dominiklohmann
Avoid an unnecessary copy
44932cd 
Co-authored-by: Dominik Lohmann <mail@dominiklohmann.de>
@tobim
Log the rate logging rate reduction in the changelog
7bc0cff
@tobim tobim force-pushed the topic/tune-node-logs branch from 1e3e92b to 7bc0cff Compare September 1, 2020 10:38
dominiklohmann
dominiklohmann approved these changes Sep 1, 2020
View reviewed changes
Copy link
Member

@dominiklohmann dominiklohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tobim tobim merged commit 92a0dfe into master Sep 1, 2020
@tobim tobim deleted the topic/tune-node-logs branch September 1, 2020 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominiklohmann dominiklohmann dominiklohmann approved these changes

Assignees
No one assigned
Labels
maintenance Tasks for keeping up the infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tobim @dominiklohmann