Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable settings conversion to CAF #1055

Merged
merged 4 commits into from
Sep 16, 2020
Merged

Enable settings conversion to CAF #1055

merged 4 commits into from
Sep 16, 2020

Conversation

mavam
Copy link
Member

@mavam mavam commented Sep 10, 2020

No description provided.

@mavam mavam marked this pull request as ready for review September 15, 2020 09:34
@mavam mavam requested a review from a team September 15, 2020 09:34
Copy link
Member

@dominiklohmann dominiklohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly fine by me except for one small, subtle issue in the code.

Please change the test record for the unit test such that it contains a list that contains at least one different type, e.g., record.

I did not test this locally; the unit tests running through cover this functionality quite well.

@mavam mavam mentioned this pull request Sep 15, 2020
2 tasks
Copy link
Member

@dominiklohmann dominiklohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as is, just one remark/question: Why did you move from caf::settings to caf::dictionary<caf::config_value>? The former is an alias of the latter, but I find caf::settings to be the more idiomatic type to enable conversion to.

@mavam
Copy link
Member Author

mavam commented Sep 16, 2020

Why did you move from caf::settings to caf::dictionary<caf::config_value>?

The reason is that caf::settings is just a top-level alias. The real recursive structure is a config_value and this is what I'd like the user of the API to remember: a config_value can contain a dictionary of config_values. Since the recursion occurs in the implementation, I find it cleaning to stick to a single set of vocabulary.

@mavam mavam merged commit 7157e8f into master Sep 16, 2020
@mavam mavam deleted the story/ch19315 branch September 16, 2020 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants