Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace PID file if process does not exist #1128

Merged
merged 3 commits into from
Oct 31, 2020
Merged

Replace PID file if process does not exist #1128

merged 3 commits into from
Oct 31, 2020

Conversation

tobim
Copy link
Member

@tobim tobim commented Oct 29, 2020

📔 Description

Change to PID file check so that it automatically gets replaced if the owning process does not exist any more.

📝 Checklist

  • All user-facing changes have changelog entries.
  • The changes are reflected on docs.tenzir.com/vast, if necessary.
  • The PR description contains instructions for the reviewer, if necessary.

🎯 Review Instructions

Please test this change locally.

  1. Try to run vast -d somedir start 2 times in parallel, without stopping the first process.
  2. Try to run vast -d somedir start 2 times sequentially; kill the first process before spawning the second.

@tobim tobim requested a review from a team October 29, 2020 12:30
mavam
mavam requested changes Oct 29, 2020
View reviewed changes
Copy link
Member

@mavam mavam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'd just add a changelog entry.

mavam
mavam approved these changes Oct 30, 2020
View reviewed changes
Copy link
Member

@mavam mavam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge, modulo a request for the changelog entry.

@tobim @mavam
Improve wording in the changelog
75c0f97 
Co-authored-by: Matthias Vallentin <matthias@tenzir.com>
@tobim tobim merged commit 473351c into master Oct 31, 2020
@tobim tobim deleted the story/ch20219/replace-dead-node branch October 31, 2020 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mavam mavam mavam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tobim @mavam