Allow for extending the table slice FlatBuffers table #1143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiklohmann
force-pushed
the
topic/table-slice-legacy
branch
from
1e94569 to
bf879a8
Compare
10 tasks
tobim
reviewed
Nov 5, 2020
dominiklohmann
force-pushed
the
topic/table-slice-legacy
branch
2 times, most recently
from
9f7b702 to
560b3ae
Compare
This renames `vast.fbs.table_slice_buffer.v0` to `vast.fbs.FlatTableSlice`, and removes its erroneous root type declaration.
dominiklohmann
force-pushed
the
topic/table-slice-legacy
branch
from
560b3ae to
b5cf3d8
Compare
tobim
approved these changes
Nov 5, 2020
libvast/vast/table_slice_visit.hpp
Outdated
Comment on lines
35
to
36
| std::disjunction<std::is_nothrow_invocable<Visitor>, | ||
| std::negation<std::is_invocable<Visitor>>>, |
There was a problem hiding this comment.
This is kinda hard to understand. We have 3 cases here:
| throws | nothrow | absent | |
|---|---|---|---|
| nothrow_invocable | false | true | false |
| not invokable | false | false | true |
| or | false | true | true |
So it is correct. We could think about switching the order, I assume the default will usually be absent.
There was a problem hiding this comment.
It should be about 50-50. Currently there's lots of missing defaults, but that is only because we necessarily use it outside of table_slice.cpp. I still agree with changing the order, as that makes it easier to read in my opinion.
Ideally, we can move the visit function inside table_slice.cpp in the future and stop exposing the underlying FlatBuffers table at all.
There was a problem hiding this comment.
I have reversed the order as suggested and rebased to get rid of all fixup! commits.
dominiklohmann
force-pushed
the
topic/table-slice-legacy
branch
from
b5cf3d8 to
7cbc3e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📔 Description
The third PR to be merged into #1140. This set of changes wraps the existing table slice FlatBuffers table in a union, and cleans up the
table_slice.fbsfile accordingly, and adds a utility function for visiting table slice encodings.📝 Checklist
🎯 Review Instructions
Commit-by-commit works best for this PR.