Skip to content

Show file size information in lsvast #1149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 13, 2020
Merged

Show file size information in lsvast #1149

merged 1 commit into from
Nov 13, 2020

Conversation

lava
Copy link
Member

@lava lava commented Nov 5, 2020 •
edited
Loading

📔 Description

📝 Checklist

  • All user-facing changes have changelog entries.
  • The changes are reflected on docs.tenzir.com/vast, if necessary.
  • The PR description contains instructions for the reviewer, if necessary.

🎯 Review Instructions

@lava lava changed the title wip: file size information in lsvast Show file size information in lsvast Nov 5, 2020
@lava lava force-pushed the topic/lsvast-filesizes branch from f710eaf to 78235bf Compare November 6, 2020 15:36
@mavam
Copy link
Member

mavam commented Nov 9, 2020

There is a lot of code for just formatting. How about using vast::data to store the contents and then simply render it as JSON?

@lava lava force-pushed the topic/lsvast-filesizes branch from 78235bf to 6371edb Compare November 10, 2020 13:47
@lava lava marked this pull request as ready for review November 10, 2020 13:48
@lava lava force-pushed the topic/lsvast-filesizes branch from 6371edb to d3cea87 Compare November 11, 2020 14:51
mavam
mavam reviewed Nov 11, 2020
View reviewed changes
Copy link
Member

@mavam mavam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still getting hex output for the number of rows. Am I doing something wrong?

@lava lava force-pushed the topic/lsvast-filesizes branch from d3cea87 to 42dbdb1 Compare November 12, 2020 17:57
@lava
Copy link
Member Author

lava commented Nov 12, 2020

I'm still getting hex output for the number of rows. Am I doing something wrong?

No, I didn't realize std::hex was sticky after use. Should be fixed now.

mavam
mavam requested changes Nov 13, 2020
View reviewed changes
Copy link
Member

@mavam mavam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this with my local DB, both using just the dir as argument and -h. Looks good. Just one small change request regarding the representation of plain bytes.

@lava lava force-pushed the topic/lsvast-filesizes branch from 42dbdb1 to a8f0852 Compare November 13, 2020 13:42
@lava lava requested a review from mavam November 13, 2020 13:42
@lava lava force-pushed the topic/lsvast-filesizes branch from a8f0852 to 845e6b9 Compare November 13, 2020 14:44
@lava
Add 'lsvast' options to print sizes
ce207ed 
Add some options to lsvast to be able to optionally print the on-disk
sizes of certain data structures in the partition and segment
flatbuffers.
@lava lava force-pushed the topic/lsvast-filesizes branch from 845e6b9 to ce207ed Compare November 13, 2020 15:14
@lava lava merged commit e706e4b into master Nov 13, 2020
@lava lava deleted the topic/lsvast-filesizes branch November 13, 2020 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mavam mavam mavam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lava @mavam