Skip to content

Reply to status requests in sinks #1155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 9, 2020
Merged

Conversation

dominiklohmann
Copy link
Member

@dominiklohmann dominiklohmann commented Nov 9, 2020

📔 Description

This errored previously, which was most noticeable for continuous exports.

❯ vast -v quiet status --detailed | jq .sinks
[
  {
    "format": "json-writer",
    "processed": 378
  }
]

📝 Checklist

  • All user-facing changes have changelog entries.
  • The changes are reflected on docs.tenzir.com/vast, if necessary.
  • The PR description contains instructions for the reviewer, if necessary.

🎯 Review Instructions

Read the relatively simple code. Run locally by running a continuous or unified export command and sending a status request.

@dominiklohmann dominiklohmann added the bug Incorrect behavior label Nov 9, 2020
@dominiklohmann dominiklohmann requested a review from a team November 9, 2020 17:46
@dominiklohmann dominiklohmann force-pushed the story/ch20531/sink-status branch from ec04727 to e744947 Compare November 9, 2020 17:48
@mavam
Copy link
Member

mavam commented Nov 9, 2020

Mind giving it a rebase?

@dominiklohmann dominiklohmann force-pushed the story/ch20531/sink-status branch from e744947 to d46ad37 Compare November 9, 2020 20:53
@dominiklohmann
Copy link
Member Author

Mind giving it a rebase?

Sure, done.

Copy link
Member

@mavam mavam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this with a continuous query: vast status returns the expected output.

@dominiklohmann dominiklohmann merged commit 9cbaf8a into master Nov 9, 2020
@dominiklohmann dominiklohmann deleted the story/ch20531/sink-status branch November 9, 2020 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants