Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement new Arrow-encoded table slices #1160

Merged
merged 3 commits into from
Nov 13, 2020
Merged

Implement new Arrow-encoded table slices #1160

merged 3 commits into from
Nov 13, 2020

Conversation

dominiklohmann
Copy link
Member

📔 Description

The sixth PR to be merged into #1140. This one re-implements Arrow-encoded table slices to use FlatBuffers directly.

📝 Checklist

  • All user-facing changes have changelog entries.
  • The changes are reflected on docs.tenzir.com/vast, if necessary.
  • The PR description contains instructions for the reviewer, if necessary.

🎯 Review Instructions

This is just a single commit; view file-by-file and compare to MessagePack-encoded table slices (#1157).

@dominiklohmann dominiklohmann added refactoring Restructuring of existing code enhancement ✨ labels Nov 11, 2020
@dominiklohmann dominiklohmann requested a review from tobim November 11, 2020 16:25
@dominiklohmann dominiklohmann mentioned this pull request Nov 11, 2020
Merged
10 tasks
@dominiklohmann dominiklohmann force-pushed the topic/table-slice-arrow branch 3 times, most recently from 7a35ecc to 2f1bd21 Compare November 11, 2020 19:11
Base automatically changed from topic/table-slice-perf to topic/table-slice-msgpack November 12, 2020 14:02
Base automatically changed from topic/table-slice-msgpack to epic/flatbuffers-persistence-table-slices November 12, 2020 15:01
tobim
tobim reviewed Nov 12, 2020
View reviewed changes
@dominiklohmann dominiklohmann force-pushed the topic/table-slice-arrow branch from c9825ed to 02b7277 Compare November 12, 2020 16:12
@dominiklohmann dominiklohmann force-pushed the topic/table-slice-arrow branch 2 times, most recently from 6ac386c to a1f12da Compare November 12, 2020 17:00
@dominiklohmann dominiklohmann force-pushed the topic/table-slice-arrow branch from a1f12da to 1e0bc2d Compare November 12, 2020 17:01
@dominiklohmann dominiklohmann requested a review from tobim November 12, 2020 20:06
tobim
tobim approved these changes Nov 13, 2020
View reviewed changes
Copy link
Member

@tobim tobim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as before.

@dominiklohmann dominiklohmann merged commit ea4c061 into epic/flatbuffers-persistence-table-slices Nov 13, 2020
@dominiklohmann dominiklohmann deleted the topic/table-slice-arrow branch November 13, 2020 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobim tobim tobim approved these changes

Assignees
No one assigned
Labels
refactoring Restructuring of existing code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dominiklohmann @tobim