Remove legacy table slices and table slice factory #1165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
dominiklohmann
force-pushed
the
topic/table-slice-legacy-removal
branch
2 times, most recently
from
89ff720 to
dddec1b
Compare
tobim
reviewed
Nov 13, 2020
tobim
approved these changes
Nov 13, 2020
dominiklohmann
force-pushed
the
topic/table-slice-legacy-removal
branch
from
dddec1b to
70966ef
Compare
Base automatically changed from
topic/table-slice-arrow
to
epic/flatbuffers-persistence-table-slices
November 13, 2020 14:54
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📔 Description
The seventh and last PR to be merged into #1140—this one removes all the stuff that we no longer need and does some much-needed cleanup.
📝 Checklist
🎯 Review Instructions
This one's really simple: It basically just removes stuff and does some minor cleanup. I suggest going over it commit-by-commit.