Skip to content

Set fallback port for underspecified endpoints #1170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 16, 2020
Merged

Set fallback port for underspecified endpoints #1170

merged 1 commit into from
Nov 16, 2020

Conversation

dominiklohmann
Copy link
Member

@dominiklohmann dominiklohmann commented Nov 16, 2020 •
edited
Loading

📔 Description

Sets a fallback port of 42000 when the vast.endpoint option is set, but does not contain a port.

📝 Checklist

  • All user-facing changes have changelog entries.
  • The changes are reflected on docs.tenzir.com/vast, if necessary.
  • The PR description contains instructions for the reviewer, if necessary.

🎯 Review Instructions

Run vast -e localhost start with and without this change to verify this works.

@dominiklohmann dominiklohmann added the bug Incorrect behavior label Nov 16, 2020
@dominiklohmann dominiklohmann requested a review from a team November 16, 2020 10:20
mavam
mavam reviewed Nov 16, 2020
View reviewed changes
Copy link
Member

@mavam mavam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense overall.

Is it still possible to explicitly specify 0 as port to get a random port that is available on the system?

@dominiklohmann dominiklohmann requested a review from mavam November 16, 2020 14:32
@dominiklohmann dominiklohmann force-pushed the story/ch20651/random-port branch from 04df03a to 255dde2 Compare November 16, 2020 14:32
@dominiklohmann dominiklohmann requested a review from tobim November 16, 2020 14:32
mavam
mavam reviewed Nov 16, 2020
View reviewed changes
@dominiklohmann dominiklohmann force-pushed the story/ch20651/random-port branch from 255dde2 to 1736f7b Compare November 16, 2020 14:44
@dominiklohmann dominiklohmann requested a review from mavam November 16, 2020 14:45
mavam
mavam requested changes Nov 16, 2020
View reviewed changes
@dominiklohmann dominiklohmann force-pushed the story/ch20651/random-port branch from 1736f7b to 1faecbd Compare November 16, 2020 15:08
@dominiklohmann dominiklohmann requested a review from mavam November 16, 2020 15:08
@dominiklohmann dominiklohmann force-pushed the story/ch20651/random-port branch from 1faecbd to 7c7d0df Compare November 16, 2020 15:25
mavam
mavam reviewed Nov 16, 2020
View reviewed changes
Copy link
Member

@mavam mavam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this locally and it works. For example, vast -e 0.0.0.0 start no longer opens a random high-level port.

@dominiklohmann dominiklohmann merged commit 9feb390 into master Nov 16, 2020
@dominiklohmann dominiklohmann deleted the story/ch20651/random-port branch November 16, 2020 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mavam mavam mavam approved these changes

@tobim tobim Awaiting requested review from tobim

Assignees
No one assigned
Labels
bug Incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dominiklohmann @mavam @tobim