Skip to content

Add RDP schema record type and missing TLS fields #1186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 19, 2020
Merged

Add RDP schema record type and missing TLS fields #1186

merged 4 commits into from
Nov 19, 2020

Conversation

satta
Copy link
Contributor

@satta satta commented Nov 19, 2020

📔 Description

Add a new record type in the Suricata schema for RDP and add, among others, the missing tls.sni field that would be required for some applications involving domain indicators.

📝 Checklist

  • All user-facing changes have changelog entries.
  • The changes are reflected on docs.tenzir.com/vast, if necessary. (n/a)
  • The PR description contains instructions for the reviewer, if necessary. (n/a)

🎯 Review Instructions

Just double-check the syntax please.

satta added 3 commits November 19, 2020 17:23
@satta
add schema for missing rdp type
5946517
@satta
add missing fields in 'tls' schema type
d142116 
This commit adds the previously missing 'sni' and
'session_resumed' fields.
@satta
extend CHANGELOG.md
a22dbfb
mavam
mavam reviewed Nov 19, 2020
View reviewed changes
Copy link
Member

@mavam mavam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

@mavam mavam requested a review from dominiklohmann November 19, 2020 17:05
@satta @mavam
add pull request number
ab76a80 
Co-authored-by: Matthias Vallentin <vallentin@icir.org>
dominiklohmann
dominiklohmann approved these changes Nov 19, 2020
View reviewed changes
Copy link
Member

@dominiklohmann dominiklohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright to me. The fields match what Suricata exports.

This change by itself is not breaking, because it's a strict superset of the old schema.

@dominiklohmann dominiklohmann merged commit 4f32bb0 into tenzir:master Nov 19, 2020
@satta satta deleted the schemastuff2 branch November 19, 2020 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mavam mavam mavam left review comments

@dominiklohmann dominiklohmann dominiklohmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@satta @mavam @dominiklohmann