Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move schema definitions into subdirectory #1194

Merged
merged 3 commits into from
Nov 24, 2020

Conversation

dominiklohmann
Copy link
Member

@dominiklohmann dominiklohmann commented Nov 23, 2020

📔 Description

The schema definitions now live in the schema/types/ subdirectory.

I verified that no changes to the installation process are necessary in our CMake.

📝 Checklist

  • All user-facing changes have changelog entries.
  • The changes are reflected on docs.tenzir.com/vast, if necessary.
  • The PR description contains instructions for the reviewer, if necessary.

🎯 Review Instructions

n/t

@dominiklohmann dominiklohmann added the maintenance Tasks for keeping up the infrastructure label Nov 23, 2020
@dominiklohmann dominiklohmann requested a review from a team November 23, 2020 17:13
Copy link
Member

@mavam mavam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The YAML files are concept definitions. IIRC, we wanted to have those in schema/concepts.

@dominiklohmann dominiklohmann requested a review from mavam November 24, 2020 09:34
@dominiklohmann dominiklohmann force-pushed the story/ch20828/schema-subdirectory branch from b8f57ab to ebebf82 Compare November 24, 2020 09:34
@dominiklohmann
Copy link
Member Author

This is also ready for review again.

Copy link
Member

@mavam mavam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

This doesn't need manual testing as long as CI checks out.

@dominiklohmann dominiklohmann merged commit ff2f274 into master Nov 24, 2020
@dominiklohmann dominiklohmann deleted the story/ch20828/schema-subdirectory branch November 24, 2020 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Tasks for keeping up the infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants