Skip to content

Send correct message to index when dropping further results #1209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 3, 2020
Merged

Send correct message to index when dropping further results #1209

merged 1 commit into from
Dec 3, 2020

Conversation

lava
Copy link
Member

@lava lava commented Dec 3, 2020

📔 Description

📝 Checklist

  • All user-facing changes have changelog entries.
  • The changes are reflected on docs.tenzir.com/vast, if necessary.
  • The PR description contains instructions for the reviewer, if necessary.

🎯 Review Instructions

@lava lava added the bug Incorrect behavior label Dec 3, 2020
dominiklohmann
dominiklohmann approved these changes Dec 3, 2020
View reviewed changes
Copy link
Member

@dominiklohmann dominiklohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this without further testing, we found this while pair-programming.

@dominiklohmann dominiklohmann merged commit 027e06f into master Dec 3, 2020
@dominiklohmann dominiklohmann deleted the topic/exporter-index-communication branch December 3, 2020 18:27
dominiklohmann added a commit that referenced this pull request Dec 4, 2020
@dominiklohmann
Add missing changelog entry for #1209
d1be812
dominiklohmann added a commit that referenced this pull request Dec 4, 2020
@dominiklohmann
Add missing changelog entry for #1209
982e9f5
@dominiklohmann dominiklohmann mentioned this pull request Dec 4, 2020
Merged
3 tasks
dominiklohmann added a commit that referenced this pull request Dec 4, 2020
@dominiklohmann
Merge pull request #1213
ed912d5 
Add missing changelog entry for #1209
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominiklohmann dominiklohmann dominiklohmann approved these changes

Assignees
No one assigned
Labels
bug Incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lava @dominiklohmann