Add support for type-level synopses and a string synopsis #1214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mavam
reviewed
Dec 4, 2020
mavam
reviewed
Dec 4, 2020
mavam
reviewed
Dec 6, 2020
There was a problem hiding this comment.
Why do we need the class string_synopsis? Can't we just use a buffered_bloom_filter_synopsis or buffered_bloom_filter_synopsis<T> if we want to restrict it to a single type? I would argue the lookup function can have a precondition that it was already type-checked and that it can be fully polymorphic.
A related question: how does that buffered_string_synopsis behave differently from the buffered_address_synopsis?
tobim
force-pushed
the
topic/string-synopsis
branch
from
934e5bc to
8e94807
Compare
mavam
reviewed
Dec 8, 2020
tobim
force-pushed
the
topic/string-synopsis
branch
2 times, most recently
from
fef1295 to
77c4119
Compare
lava
force-pushed
the
topic/string-synopsis
branch
4 times, most recently
from
ec6412a to
3599ba6
Compare
dominiklohmann
approved these changes
Dec 16, 2020
tobim
commented
Dec 16, 2020
lava
force-pushed
the
topic/string-synopsis
branch
2 times, most recently
from
c3f73c5 to
8bc3f4b
Compare
lava
force-pushed
the
topic/string-synopsis
branch
from
8bc3f4b to
56ee0c8
Compare
Previously, when faced with a query like
zeek.dns.query == "example.org"
and a database that does not contain any zeek.dns records,
the meta index would schedule *all* partitions since no
synopsis existed that could rule out any particular partition.
With this change, we also ignore partitions that have no potential
matches at all.
* Unify `buffered_address_synopsis` and `buffered_string_synopsis`
into a single `buffered_synopsis<T>`.
* String attributes in meta index before checking type equality.
* Rename `fprate` to `fp-rate` globally.
* Correctly apply past tense of `shrink` where necesary.
lava
force-pushed
the
topic/string-synopsis
branch
from
56ee0c8 to
67eaf64
Compare
mavam
reviewed
Dec 16, 2020
| @@ -12,6 +12,10 @@ Every entry has a category for which we use the following visual abbreviations: | |||
|
|
|||
| ## Unreleased | |||
|
|
|||
| - 🎁 A new type-level synopsis structure in the meta-index now massively | |||
| speeds up string queries with very few results. | |||
| [#1214](https://github.com/tenzir/vast/pull/1214) | |||
There was a problem hiding this comment.
This is another case where I don't see the need for a "feature" changelog. It's a non-functional change.
It would only make sense to introduce a performance-related category where we document performance-affecting changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📔 Description
This adds support for type-level synopses to the meta index. For each field in a partition, it is possible to decide whether to use a specific synopsis, share one with the other fields of the same type, or not to use a synopsis at all.
A new string synopsis and buffered string synopsis is also introduced.
📝 Checklist
🎯 Review Instructions
By commit.