Support -v, -vv, -vvv, -q, -qq, -qqq for verbosity #1244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiklohmann
force-pushed
the
story/ch13943/vvvvvvvvv
branch
from
1f4772a to
887d1b3
Compare
mavam
reviewed
Dec 17, 2020
|short option|long option| |-|-| |-qqq|--verbosity=quiet| |-qq|--verbosity=error| |-q|--verbosity=warning| ||--verbosity=info (default)| |-v|--verbosity=verbose| |-vv|--verbosity=debug| |-vvv|--verbosity=trace|
mavam
reviewed
Dec 17, 2020
There was a problem hiding this comment.
I tested this as follows:
vast start
vast -v start
vast -vv start
vast -vvv start
All good. Then I tried the "quiet" mode by trying to bind twice to the same port with two instances of vast start.
vast -q start
!! filesystem_error: "PID file found: " "[..]/vast.db/pid.lock" "terminate process" "95957"
I get this for all variations of quietness, i.e., -q, -qq, and -qqq. Is this expected behavior?
dominiklohmann
force-pushed
the
story/ch13943/vvvvvvvvv
branch
from
e23cf91 to
e5e6314
Compare
Yes, because that error is printed on stderr, and without going through any of our logger macros. |
mavam
approved these changes
Dec 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📔 Description
📝 Checklist
🎯 Review Instructions
Try it!