Gracefully deal with JSON to data conversion errors #1250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mavam
reviewed
Dec 21, 2020
mavam
reviewed
Dec 21, 2020
libvast/src/format/json.cpp
Outdated
| err = make_error(ec::convert_error); | ||
| err.context() += x.error().context(); | ||
| err.context() += caf::make_message("could not convert", field.name, ":", | ||
| to_string(*i)); |
There was a problem hiding this comment.
Why do you use += twice?
Can you give an example of how a "multi-field" error would look like?
There was a problem hiding this comment.
This is an example with 2 conversion errors in one line:
vast.format.json.reader failed to convert value(s) in line 1 : !! convert_error: "long%20double" "to" "vast.string_type" "pcap_cnt" "is" "83" ";" "long%20double" "to" "vast.string_type" "src_port" "is" "1181" ";"
There was a problem hiding this comment.
While it may be complete in terms of information, it's pretty rough to understand.
In the future, we probably want to use std::format to print a human-readable error message, so for now I'm fine with keeping it as is.
mavam
approved these changes
Dec 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📔 Description
📝 Checklist
🎯 Review Instructions
Please test modifying the suricata schema and ingesting test data from the repo. Everything but the modified field should remain intact upon export.