Add the import zeek-json command #1259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
mavam
reviewed
Jan 6, 2021
mavam
approved these changes
Jan 6, 2021
Running with -u creates this file. Although it is not strictly an error not to have this file, let's just include it so there's no diff at all when running with -u.
dominiklohmann
force-pushed
the
story/ch21379/corelight-json
branch
from
e6a5cf1 to
0a31430
Compare
|
I rebased this because of a conflict in the changelog file. No further changes were made. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📔 Description
This refactors the Suricata selector to be more generic, and makes use of that change to implement a Zeek JSON selector.
📝 Checklist
🎯 Review Instructions
Commit-by-commit.
Note that this requires a companion PR to the documentation, which we should merge first.Done.