Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename *-paths to *-dirs options #1287

Merged
merged 5 commits into from
Jan 18, 2021
Merged

Rename *-paths to *-dirs options #1287

merged 5 commits into from
Jan 18, 2021

Conversation

dominiklohmann
Copy link
Member

@dominiklohmann dominiklohmann commented Jan 18, 2021 •
edited
Loading

📔 Description

The *-paths option in our vast.yaml feel really confusing. A directory is necessarily a path, but not the other way round.

The old options continue to work, but are deprecated.

📝 Checklist

  • All user-facing changes have changelog entries.
  • The changes are reflected on docs.tenzir.com/vast, if necessary.
  • The PR description contains instructions for the reviewer, if necessary.

🎯 Review Instructions

Try it out locally.

@dominiklohmann
Rename *-paths to *-dirs options
59e623d 
The `*-paths` option in our `vast.yaml` feel really confusing. A
directory is necessarily a path, but not the other way round.

The old options continue to work, but are deprecated.
@dominiklohmann dominiklohmann requested a review from a team January 18, 2021 12:38
@dominiklohmann dominiklohmann marked this pull request as ready for review January 18, 2021 12:42
@tenzir tenzir deleted a comment from shortcut-integration bot Jan 18, 2021
tobim
tobim reviewed Jan 18, 2021
View reviewed changes
Copy link
Member

@tobim tobim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not much to say, tested and observed the behavior that I commented on below.

@dominiklohmann dominiklohmann requested a review from tobim January 18, 2021 14:29
mavam
mavam reviewed Jan 18, 2021
View reviewed changes
@dominiklohmann @mavam
Improve changelog entry
a718f5d 
Co-authored-by: Matthias Vallentin <matthias@tenzir.com>
mavam
mavam reviewed Jan 18, 2021
View reviewed changes
@dominiklohmann
Remove legacy plugin-paths option
bf4d0b7 
It was only introduced after the most recent release, so it does not
need to stay in marked as deprecated.
@dominiklohmann dominiklohmann requested a review from mavam January 18, 2021 14:54
tobim
tobim approved these changes Jan 18, 2021
View reviewed changes
Copy link
Member

@tobim tobim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work as intended. It even prints the warning twice for emphasis 😛 .

@dominiklohmann
Copy link
Member Author

It even prints the warning twice for emphasis 😛 .

Noticed that as well, we seem to read the schemas twice on startup. I'll write a story so we don't forget about that.

@dominiklohmann dominiklohmann merged commit 7dc57c4 into master Jan 18, 2021
@dominiklohmann dominiklohmann deleted the story/ch21897/paths-to-dirs branch January 18, 2021 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobim tobim tobim approved these changes

@mavam mavam Awaiting requested review from mavam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dominiklohmann @mavam @tobim