Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate Dockerfiles #1294

Merged
merged 5 commits into from
Jan 26, 2021
Merged

Consolidate Dockerfiles #1294

merged 5 commits into from
Jan 26, 2021

Conversation

0snap
Copy link
Contributor

@0snap 0snap commented Jan 20, 2021

📔 Description

  • consolidate Dockerfiles
  • update CI workflow to test Dockerfile
  • update general CI workflow

📝 Checklist

  • All user-facing changes have changelog entries.
  • The changes are reflected on docs.tenzir.com/vast, if necessary.
  • The PR description contains instructions for the reviewer, if necessary.

🎯 Review Instructions

@0snap 0snap changed the title Story/ch21833 Consolidate Dockerfiles Jan 20, 2021
@0snap 0snap force-pushed the story/ch21833 branch 27 times, most recently from 097d652 to b9a069b Compare January 21, 2021 16:08
@0snap 0snap marked this pull request as ready for review January 21, 2021 16:24
@0snap 0snap requested a review from dominiklohmann January 21, 2021 16:25
@dominiklohmann dominiklohmann self-assigned this Jan 21, 2021
@dominiklohmann dominiklohmann added enhancement ✨ maintenance Tasks for keeping up the infrastructure labels Jan 21, 2021
dominiklohmann
dominiklohmann reviewed Jan 25, 2021
View reviewed changes
Copy link
Member

@dominiklohmann dominiklohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We must factor in the changes from #1310 as well.

@0snap 0snap force-pushed the story/ch21833 branch 4 times, most recently from 493c875 to 9b23ba9 Compare January 26, 2021 10:40
mavam
mavam reviewed Jan 26, 2021
View reviewed changes
@0snap
Copy link
Contributor Author

0snap commented Jan 26, 2021

@dominiklohmann CI turned green and I verified the GCC-8 artifact as follows:

  • download the zip (vast-2020.12.16-363-g16ee0a423-linux-release-gcc.tar.gz.zip)
  • unpack it inside the vast repo to a (sub-)folder called opt/vast
  • run DOCKER_BUILDKIT=1 docker build . -t vast-build-pre --build-arg DOCKER_BUILD=prebuilt
  • test the prebuilt image: docker run vast-build-pre -> prints vast help

@dominiklohmann
Copy link
Member

Thanks for the instructions. I'll try this locally shortly, and will also try to confirm the completeness of the VAST installation.

mavam
mavam reviewed Jan 26, 2021
View reviewed changes
dominiklohmann
dominiklohmann approved these changes Jan 26, 2021
View reviewed changes
Copy link
Member

@dominiklohmann dominiklohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this extensively. Everything works as expected, and I think this is a major improvement that is worth the additional effort to maintain our CI.

@0snap 0snap merged commit 7d6d31f into master Jan 26, 2021
@0snap 0snap deleted the story/ch21833 branch January 26, 2021 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mavam mavam mavam left review comments

@dominiklohmann dominiklohmann dominiklohmann approved these changes

Assignees

@dominiklohmann dominiklohmann

Labels
maintenance Tasks for keeping up the infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0snap @dominiklohmann @mavam