Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the example plugin slightly #1307

Merged
merged 1 commit into from
Jan 25, 2021
Merged

Improve the example plugin slightly #1307

merged 1 commit into from
Jan 25, 2021

Conversation

dominiklohmann
Copy link
Member

📔 Description

  • Use extend_with for the typed actor definition and reorder behaviors
  • Always send the configuration to the example actor

📝 Checklist

  • All user-facing changes have changelog entries.
  • The changes are reflected on docs.tenzir.com/vast, if necessary.
  • The PR description contains instructions for the reviewer, if necessary.

🎯 Review Instructions

n/t

@dominiklohmann dominiklohmann requested a review from a team January 25, 2021 10:37
@dominiklohmann dominiklohmann force-pushed the topic/example-plugin-fixups branch from d26acfa to a3d7bc2 Compare January 25, 2021 10:38
@dominiklohmann
Improve the example plugin slightly
94183f5 
- Use extend_with for the typed actor definition and reorder behaviors
- Always send the configuration to the example actor
@dominiklohmann dominiklohmann force-pushed the topic/example-plugin-fixups branch from a3d7bc2 to 94183f5 Compare January 25, 2021 11:15
mavam
mavam approved these changes Jan 25, 2021
View reviewed changes
Copy link
Member

@mavam mavam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; didn't run additional local tests.

@dominiklohmann dominiklohmann merged commit c5e8a09 into master Jan 25, 2021
@dominiklohmann dominiklohmann deleted the topic/example-plugin-fixups branch January 25, 2021 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mavam mavam mavam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dominiklohmann @mavam