Skip to content

Improve and generalize {fmt} formatters #1328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 2, 2021

Conversation

dominiklohmann
Copy link
Member

@dominiklohmann dominiklohmann commented Feb 1, 2021

📔 Description

See logger_formatters.hpp:

  • We now have fallback formatters based on printable and the stringification inspector.
  • id_or_name is now applied automatically.
  • Some log messages had their formatting corrected.
  • render is now automatically called on errors.
  • <unprintable> is no more.

📝 Checklist

  • All user-facing changes have changelog entries.
  • The changes are reflected on docs.tenzir.com/vast, if necessary.
  • The PR description contains instructions for the reviewer, if necessary.

🎯 Review Instructions

File-by-file.

@dominiklohmann dominiklohmann requested a review from a team February 1, 2021 17:22
@dominiklohmann dominiklohmann force-pushed the story/ch22336/formatter-improvements branch 4 times, most recently from 3e160ee to 0883670 Compare February 1, 2021 17:47
@dominiklohmann dominiklohmann force-pushed the story/ch22336/formatter-improvements branch from aef4ff1 to 1c84146 Compare February 2, 2021 09:03
Copy link
Member

@lava lava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I admittedly only sampled the diff, but what I've seen looks reasonable, and with a PR this size I think its more efficient to merge now and maybe follow-up on issues that we overlooked, rather than extending the lifetime of this PR.

@dominiklohmann dominiklohmann merged commit 6235ea3 into master Feb 2, 2021
@dominiklohmann dominiklohmann deleted the story/ch22336/formatter-improvements branch February 2, 2021 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants