Skip to content

Read user-supplied schema files from config dirs #1372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 11, 2021

Conversation

dominiklohmann
Copy link
Member

@dominiklohmann dominiklohmann commented Feb 11, 2021

📔 Description

This change allows users to specify additional schema files in <SYSCONFDIR>/vast/schema and <XDG_CONFIG_HOME>/vast/schema.

The directory <XDG_DATA_HOME>/vast/schema is no longer considered for additional schema files.

📝 Checklist

  • All user-facing changes have changelog entries.
  • The changes are reflected on docs.tenzir.com/vast, if necessary.
  • The PR description contains instructions for the reviewer, if necessary.

🎯 Review Instructions

n/t

@dominiklohmann dominiklohmann added the bug Incorrect behavior label Feb 11, 2021
@dominiklohmann dominiklohmann requested review from a team February 11, 2021 15:34
@dominiklohmann dominiklohmann force-pushed the topic/fix-user-config-schemas branch from 1c2d328 to d74bd87 Compare February 11, 2021 15:36
This change allows users to specify additional schema files in
`<SYSCONFDIR>/vast/schema` and `<XDG_CONFIG_HOME>/vast/schema`.

The directory `<XDG_DATA_HOME>/vast/schema` is no longer considered for
additional schema files.
@dominiklohmann dominiklohmann force-pushed the topic/fix-user-config-schemas branch from d74bd87 to 3786850 Compare February 11, 2021 15:37
Copy link
Member

@mavam mavam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

Just a small style nit.

Co-authored-by: Matthias Vallentin <matthias@tenzir.com>
@dominiklohmann dominiklohmann merged commit f8332b8 into master Feb 11, 2021
@dominiklohmann dominiklohmann deleted the topic/fix-user-config-schemas branch February 11, 2021 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants