Expand subnet value predicates #1373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mavam
added
feature
dominiklohmann
requested changes
Feb 12, 2021
There was a problem hiding this comment.
There's a problem with the current implementation.
Instead of expanding just value predicates, it expands any expression :subnet == <subnet>, making it impossible to query just for subnets by equality.
In a call with @mavam we discussed two possible options:
- Move the expansion into the parser.
- Make value predicates valid predicates, i.e., don't expand them during parsing at all.
The second one would be a larger refactoring, so we'll likely opt for the first. The documentation should be rewritten accordingly to make clear this only affects value predicates.
Previously, we used to perform this inside the predicate parser. However, this makes it impossible to understand whether value predicate expansion occurred already during expression parsing. By hositing the expansion procedure, we can now perform more powerful expansions that result in multiple predicates.
dominiklohmann
approved these changes
Feb 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📔 Description
This PR expands value predicates of type
subnetas follows: given a subnetS, the parser expands it to:subnet == Sand the normalization then further to:subnet == S || :addr in S.📝 Checklist
🎯 Review Instructions
File by file.