Skip to content

Enable type extractors to support user defined types #1382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 22, 2021

Conversation

tobim
Copy link
Member

@tobim tobim commented Feb 16, 2021

📔 Description

This brings back the possibility to run vast count ":port == 80".

📝 Checklist

  • All user-facing changes have changelog entries.
  • The changes are reflected on docs.tenzir.com/vast, if necessary.
  • The PR description contains instructions for the reviewer, if necessary.
  • Add an integration test.

🎯 Review Instructions

By commit.

@tobim tobim force-pushed the story/ch22834/udt-type-extractor branch 2 times, most recently from cbb0b59 to 7567973 Compare February 17, 2021 18:24
@tobim tobim requested a review from a team February 17, 2021 18:30
@tobim tobim marked this pull request as ready for review February 17, 2021 18:30
Copy link
Member

@mavam mavam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

I looked at the diff in detail and the implementation checks out. Nothing needs to be changed. I couldn't give it a spin locally right now, but it looks really good.

If somebody else could check out the branch to validate the hands-on behavior, that'd be great. The code is in good shape.

@tobim tobim force-pushed the story/ch22834/udt-type-extractor branch from 7fdff0f to 8d3d115 Compare February 18, 2021 17:15
@mavam mavam requested a review from dominiklohmann February 18, 2021 19:45
Copy link
Member

@dominiklohmann dominiklohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works nicely.

Needs a rebase and the docs need to be written and merged before this PR gets merged.

@tobim tobim force-pushed the story/ch22834/udt-type-extractor branch from 8d3d115 to 73d615c Compare February 19, 2021 15:43
@tobim tobim merged commit 6610731 into master Feb 22, 2021
@tobim tobim deleted the story/ch22834/udt-type-extractor branch February 22, 2021 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants