Let the JSON reader recover from unexpected inputs #1386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
The new JSON reader returned to early in case the parsed input could not be converted to the target type dictated by the layout. This could lead to broken table slices with underful rows. From now on it inserts a `nil` value into that cell and continues.
tobim
force-pushed
the
topic/fix-json-reader-convert
branch
from
cfd6a64 to
1d97541
Compare
mavam
reviewed
Feb 17, 2021
dominiklohmann
approved these changes
Feb 17, 2021
There was a problem hiding this comment.
I tested this locally with the example you gave me via Slack (see below, write_ts in line 2) and was able to reproduce the faulty behavior on master and the warning with this PR.
{"_path":"sip","_system_name":"sensor_10_0_0_2","_write_ts":"2021-02-01T13:23:04.768321Z","ts":"2021-02-01T13:18:04.777419Z","uid":"C6j3vyC2g0ND18JBl","id.orig_h":"217.182.199.128","id.orig_p":5132,"id.resp_h":"194.94.128.27","id.resp_p":5060,"trans_depth":0,"method":"OPTIONS","uri":"sip:100@194.94.128.27","request_from":"\"sipvicious\"<sip:100@1.1.1.1>","request_to":"\"sipvicious\"<sip:100@1.1.1.1>","call_id":"630386036184203546741250","seq":"1 OPTIONS","request_path":["SIP/2.0/UDP 217.182.199.128:5132"],"response_path":[],"user_agent":"friendly-scanner","request_body_len":0}
{"_path":"sip","_system_name":"sensor_10_0_0_2","_write_ts":"2021-02-01T13:2public","get_requests":2,"get_bulk_requests":0,"get_responses":0,"set_requests":0}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📔 Description
📝 Checklist