Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept numbers in place of strings in JSON #1439

Merged
merged 1 commit into from
Mar 12, 2021
Merged

Accept numbers in place of strings in JSON #1439

merged 1 commit into from
Mar 12, 2021

Conversation

tobim
Copy link
Member

@tobim tobim commented Mar 11, 2021

📔 Description

If the schema says string but the data is numerical, we call to_string instead of failing.

📝 Checklist

  • All user-facing changes have changelog entries.

@tobim tobim added the bug Incorrect behavior label Mar 11, 2021
@tobim tobim requested a review from a team March 11, 2021 20:35
dominiklohmann
dominiklohmann approved these changes Mar 11, 2021
View reviewed changes
Copy link
Member

@dominiklohmann dominiklohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please address my one comment before merging.

@tobim tobim force-pushed the story/ch23345/json-number-to-string branch from 585e650 to 5e702bc Compare March 11, 2021 21:30
mavam
mavam reviewed Mar 12, 2021
View reviewed changes
@tobim tobim merged commit 3e71217 into master Mar 12, 2021
@tobim tobim deleted the story/ch23345/json-number-to-string branch March 12, 2021 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mavam mavam mavam left review comments

@dominiklohmann dominiklohmann dominiklohmann approved these changes

Assignees
No one assigned
Labels
bug Incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tobim @mavam @dominiklohmann