Add '--disk-budget-check-binary' option to disk monitor #1453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mavam
reviewed
Mar 16, 2021
dominiklohmann
previously requested changes
Mar 17, 2021
There was a problem hiding this comment.
This needs a changelog entry and an integration test. The code itself seems to be working fine, I've just had some smaller nits. I tested this with a simple bash script that runs du internally.
Open questions:
- The option is not currently exposed on the command line in
application.cpp. Should we expose it? - Should we write a section on this feature on docs.tenzir.com/vast that explains why we have this and how to use it?
lava
force-pushed
the
story/ch22624/disk-monitor-external-binary
branch
2 times, most recently
from
93a9e5b to
7a9e771
Compare
lava
force-pushed
the
story/ch22624/disk-monitor-external-binary
branch
from
7a9e771 to
97941ae
Compare
3 tasks
lava
force-pushed
the
story/ch22624/disk-monitor-external-binary
branch
2 times, most recently
from
78445cd to
f9f3590
Compare
tobim
approved these changes
Mar 25, 2021
lava
force-pushed
the
story/ch22624/disk-monitor-external-binary
branch
from
51532f4 to
52f1f07
Compare
After the new `--disk-budget-check-binary` flag has been implemented, we can finally fix the existing integration test.
lava
force-pushed
the
story/ch22624/disk-monitor-external-binary
branch
from
52f1f07 to
44d1f99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📔 Description
NOTE: This is still missing some tests (after this change, we can finally write an integration test for the disk monitor!), but feel free to already review the code.
📝 Checklist
🎯 Review Instructions