Fix possibly unhandled exception in disk monitor #1458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mavam
approved these changes
Mar 17, 2021
mavam
reviewed
Mar 17, 2021
dominiklohmann
force-pushed
the
story/ch23831/fix-disk-monitor-unhandled-exception
branch
from
639f24b to
c13dae7
Compare
mavam
approved these changes
Mar 17, 2021
tobim
requested changes
Mar 17, 2021
dominiklohmann
force-pushed
the
story/ch23831/fix-disk-monitor-unhandled-exception
branch
from
1dc8881 to
33dcc05
Compare
dominiklohmann
deleted the
story/ch23831/fix-disk-monitor-unhandled-exception
branch
JoeLoser
reviewed
Mar 17, 2021
| @@ -36,7 +36,12 @@ recursive_size(const std::filesystem::path& root_dir) { | |||
| return caf::make_error(ec::filesystem_error, err.message()); | |||
| for (const auto& f : dir) { | |||
| if (f.is_regular_file()) { | |||
| const auto size = f.file_size(); | |||
| const auto size = f.file_size(err); | |||
There was a problem hiding this comment.
Sorry about this bug. My fault 😞
There was a problem hiding this comment.
No worries, we missed it during review. Your PRs are super appreciated!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📔 Description
This make
recursive_sizereturn an error instead of throw a (then unhandled) exception. The underlying root cause will need to be eliminated in a separate PR—it's not that simple to fix.📝 Checklist
🎯 Review Instructions
File-by-file.