Skip to content

Fix shutdown with importers running #1485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 23, 2021

Conversation

dominiklohmann
Copy link
Member

📔 Description

This fixes a recently introduced bug—the shutdown was not working while imports were still running.

📝 Checklist

  • All user-facing changes have changelog entries.
  • The changes are reflected on docs.tenzir.com/vast, if necessary.
  • The PR description contains instructions for the reviewer, if necessary.

🎯 Review Instructions

n/t

@dominiklohmann dominiklohmann added the bug Incorrect behavior label Mar 23, 2021
@dominiklohmann dominiklohmann requested a review from a team March 23, 2021 11:29
@dominiklohmann dominiklohmann force-pushed the story/ch24097/fix-importer-shutdown branch from 1d3cfe9 to 03aad82 Compare March 23, 2021 11:29
Copy link
Member

@lava lava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me, a regression test would be nice but as the comment already explains this is a much bigger issue we still need to solve.

@dominiklohmann dominiklohmann merged commit 053f67c into master Mar 23, 2021
@dominiklohmann dominiklohmann deleted the story/ch24097/fix-importer-shutdown branch March 23, 2021 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants