Skip to content

Remove deprecated no-default-schema option #1507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 29, 2021
Merged

Remove deprecated no-default-schema option #1507

merged 1 commit into from
Mar 29, 2021

Conversation

dominiklohmann
Copy link
Member

@dominiklohmann dominiklohmann commented Mar 29, 2021 •
edited
Loading

📔 Description

This removes the option entirely after we deprecated it with the last release.

📝 Checklist

  • All user-facing changes have changelog entries.
  • The changes are reflected on docs.tenzir.com/vast, if necessary.
  • The PR description contains instructions for the reviewer, if necessary.

🎯 Review Instructions

File-by-file. The docs were already updated when we deprecated the option.

@dominiklohmann dominiklohmann added the maintenance Tasks for keeping up the infrastructure label Mar 29, 2021
@dominiklohmann dominiklohmann requested a review from a team March 29, 2021 08:15
tobim
tobim approved these changes Mar 29, 2021
View reviewed changes
Copy link
Member

@tobim tobim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked that these are the only places that use this option. Should we add this to the changlog?

@dominiklohmann
Copy link
Member Author

Should we add this to the changlog?

Forgot to push, it's there now.

@dominiklohmann dominiklohmann force-pushed the story/ch23318/remove-deprecated-no-default-schema branch from 3767039 to ff22f99 Compare March 29, 2021 08:27
@dominiklohmann dominiklohmann merged commit 1be87e3 into master Mar 29, 2021
@dominiklohmann dominiklohmann deleted the story/ch23318/remove-deprecated-no-default-schema branch March 29, 2021 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobim tobim tobim approved these changes

Assignees
No one assigned
Labels
maintenance Tasks for keeping up the infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dominiklohmann @tobim