Allow for building plugins separately from VAST #1532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiklohmann
force-pushed
the
story/ch21757/external-plugins
branch
from
31ac39c to
02918bf
Compare
dominiklohmann
force-pushed
the
story/ch21757/external-plugins
branch
6 times, most recently
from
a9c6666 to
8ffc2f3
Compare
tobim
reviewed
Apr 8, 2021
tobim
reviewed
Apr 8, 2021
tobim
reviewed
Apr 8, 2021
tobim
approved these changes
Apr 8, 2021
|
I need to rebase this once more after #1444 is in, then I'll merge it. |
In essence, this enables the following workflow: ```bash cmake -S . -B build.vast cmake --build build.vast cmake --install build.vast cmake -S path/to/plugin -B build.plugin cmake --build build.plugin cmake --install build.plugin ```
dominiklohmann
force-pushed
the
story/ch21757/external-plugins
branch
from
8481435 to
0b8fde3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📔 Description
In essence, this enables the following workflow:
cmake -S . -B build.vast cmake --build build.vast cmake --install build.vast cmake -S path/to/plugin -B build.plugin cmake --build build.plugin cmake --install build.plugin📝 Checklist
🎯 Review Instructions
Commit-by-commit.
I still need to make it possible to run unit and integration tests, so while the first commit is reviewable this PR is not complete yet.