Fix external plugin tests with custom schemas #1541
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiklohmann
force-pushed
the
topic/external-plugins-schemas-integration-tests
branch
from
4a33a5d to
d484865
Compare
tobim
approved these changes
Apr 9, 2021
No worries, I did not catch it either and I tested quite extensively. Shit happens, just happy I finally found this. |
dominiklohmann
deleted the
topic/external-plugins-schemas-integration-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📔 Description
This fixes a particularly annoying issue: Plugins may bundle custom schemas, but running integration tests from externally built plugins did not pick them up because the plugins were in a separate build directory. Similarly to
VAST_PLUGIN_DIRS, this adds a variableVAST_SCHEMA_DIRSthat adds additional schema directories with high precedence.📝 Checklist
🎯 Review Instructions
File-by-file.