-
-
Notifications
You must be signed in to change notification settings - Fork 95
Make it possible to run VAST without user configs #1557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it possible to run VAST without user configs #1557
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having the option makes sense and is desired, but the current behavior was a bit surprising for me:
$ cat config.yaml
vast:
endpoint: "localhost:6000"
$ ./bin/vast --disable-configuration --config=config.yaml start
[13:56:51.138] loaded configuration file: "config.yaml"
[13:56:51.265] VAST node is listening on localhost:6000
Also I'd intuitively expect the environment variables to be ignored as well with this, since they're just another channel to pass configuration.
The environment variables are just another workaround because of the same ordering issue we always have when loading plugins: Plugins can modify the command structure, and the command structure is required to parse the command line. Hence why the two variables must continue working, or we break integration tests for external plugins. Similarly, |
1ba55c9
to
f3d2ca8
Compare
Fine with me, but then we should adapt the option name & description accordingly. Currently the description says that it will also disable user configuration. Something like |
f3d2ca8
to
d00f39a
Compare
I've reworded to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good now, module a few nits.
ccfdd89
to
39602b8
Compare
The new option `--bare-mode` that may only be supplied on the command line disables the loading of user (and system) configuration, schema and plugin directories. This option is used internally when generating VAST's man-page and when running integration tests.
39602b8
to
443331b
Compare
Renamed again to |
📔 Description
The new option
--disable-default-config-dirs
that may only be supplied on the command line disables the loading of user and system configuration, schema, and plugin directories. We use this option internally when generating VAST's man page and when running integration tests.📝 Checklist
🎯 Review Instructions
Commit-by-commit.