Skip to content

Fix building VAST within a shallow git tree #1570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2021

Conversation

dominiklohmann
Copy link
Member

📔 Description

This change makes it so we warn instead of fail on git-describe errors, falling back to the specified fallback version. This helps in situation where git and the source tree are available, but git-describe fails, e.g., when working from within a shallow clone.

📝 Checklist

  • All user-facing changes have changelog entries.
  • The changes are reflected on docs.tenzir.com/vast, if necessary.
  • The PR description contains instructions for the reviewer, if necessary.

🎯 Review Instructions

n/t

@dominiklohmann dominiklohmann added the bug Incorrect behavior label Apr 23, 2021
@dominiklohmann dominiklohmann requested a review from a team April 23, 2021 07:43
This change makes it so we warn instead of fail on git-describe
errors, falling back to the specified fallback version. This helps in
situation where git and the source tree are available, but git-describe
fails, e.g., when working from within a shallow clone.
Copy link
Member

@lava lava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@lava lava mentioned this pull request Apr 23, 2021
3 tasks
@dominiklohmann dominiklohmann merged commit 20c94d3 into master Apr 23, 2021
@dominiklohmann dominiklohmann deleted the topic/shallow-clone branch April 23, 2021 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants