Fix the streaming setup for analyzer plugins #1588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiklohmann
approved these changes
Apr 26, 2021
There was a problem hiding this comment.
Some nits.
To fix CI this must be rebased onto master now that #1587 is merged.
Approving as-is, but please fix the mentioned things and most importantly add a changelog entry, as this is a bug fix.
tobim
force-pushed
the
topic/fix-analyzer-setup
branch
from
cfa1f3f to
a7c4699
Compare
tobim
force-pushed
the
topic/fix-analyzer-setup
branch
from
a7c4699 to
ca89788
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📔 Description
We should not call plugin related code in the setup of core components. So the analyzer stream setup is done later now.
📝 Checklist