Load plugin schemas after built-in schemas #1608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows for plugins to override bundled schemas as part of their installation. The plugin schemas reside in `<datadir>/vast/plugin/<plugin>/schema`, while the builtin schemas reside in `<datadir>/vast/schema`. The load order guarantees that plugins are able to reliably override the schemas bundled with VAST.
dominiklohmann
force-pushed
the
story/ch23333/plugin-schemas
branch
from
b800f00 to
570a449
Compare
The "bare mode" (`vast.disable-default-config-dirs`) must also disable the developer-oriented plugin autoloading feature, otherwise the integration tests load plugins they're not supposed to load.
dominiklohmann
force-pushed
the
story/ch23333/plugin-schemas
branch
from
570a449 to
19be2da
Compare
lava
approved these changes
Apr 30, 2021
| #if !VAST_ENABLE_RELOCATABLE_INSTALLATIONS | ||
| result.insert(VAST_SCHEMADIR); | ||
| insert_dirs_for_datadir(VAST_DATADIR); | ||
| #endif |
There was a problem hiding this comment.
Not the scope of this PR, but shouldn't the loop below be in an #else block?
There was a problem hiding this comment.
That'd break integration tests from within the build directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📔 Description
This change allows for plugins to override bundled schemas as part of their installation. The plugin schemas reside in
<datadir>/vast/plugin/<plugin>/schema, while the builtin schemas reside in<datadir>/vast/schema. The load order guarantees that plugins are able to reliably override the schemas bundled with VAST.📝 Checklist
🎯 Review Instructions
Commit-by-commit.