Add a timeout option to the export command #1611
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiklohmann
force-pushed
the
story/ch24992/export-timeout
branch
from
c64dcef to
26e6df8
Compare
When running automated VAST exports, we rarely want an infinite timeout. This adds `vast export --timeout=<duration>` and `vast export --error-on-timeout` options that allow for setting a timeout to the export command. If `error-on-timeout` is enabled, cancelled exports due to a hit timeout result in a non-zero exit code.
dominiklohmann
force-pushed
the
story/ch24992/export-timeout
branch
from
26e6df8 to
fddf592
Compare
tobim
requested changes
May 3, 2021
Comment on lines
1
to
4
| The new options `vast export --timeout=<duration>` and `vast export | ||
| --error-on-timeout` allow for setting a timeout for VAST queries. If | ||
| `error-on-timeout` is enabled, cancelled exports result in a non-zero | ||
| exit code. |
There was a problem hiding this comment.
If the timeout gets hit then the exit code should ALWAYS be non-zero. The option error-on-timeout makes no sense to me.
Otherwise the functionality seems to work and the code looks ok.
There was a problem hiding this comment.
I changed it accordingly, and also fixed the symlink to vast.yaml.example from vast/integration/vast.yaml.example, which we seemed to have accidentally converted into a hard copy instead.
dominiklohmann
force-pushed
the
story/ch24992/export-timeout
branch
from
4659ee2 to
b733b7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📔 Description
When running automated VAST exports, we rarely want an infinite timeout. This adds
vast export --timeout=<duration>andvast export --error-on-timeoutoptions that allow for setting a timeout to the export command.IfCancelled exports due to a hit timeout result in a non-zero exit code.error-on-timeoutis enabled, cancelled📝 Checklist
🎯 Review Instructions
File-by-file. Test locally.