Fix the datagram source #1622
Merged
Fix the datagram source #1622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiklohmann
force-pushed
the
story/ch25162/unbreak-datagram-source
branch
from
52ece84 to
fc9c8ab
Compare
Every so often, we break the DATAGRAM SOURCE actor. This happens because we cannot make the behavior-returning `datagram_source` function returns a typed broker behavior, since that is absolutely broken in CAF 0.17.6 which we're still stuck on, and so we miss changing it when we change the interface of the SOURCE actor. But, as it turns out, we can still define the typed actor and typed broker interfaces, and simply unbox the underlying untyped behaviors before returning them. Additionally, this aligns the interfaces again so the datagram source works once more.
dominiklohmann
force-pushed
the
story/ch25162/unbreak-datagram-source
branch
from
fc9c8ab to
c95347d
Compare
lava
approved these changes
May 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📔 Description
Every so often, we break the DATAGRAM SOURCE actor. This happens because we cannot make the behavior-returning
datagram_sourcefunction returns a typed broker behavior, since that is absolutely broken in CAF 0.17.6 which we're still stuck on, and so we miss changing it when we change the interface of the SOURCE actor. But, as it turns out, we can still define the typed actor and typed broker interfaces, and simply unbox the underlying untyped behaviors before returning them.Additionally, this aligns the interfaces again so the datagram source works once more.
📝 Checklist
🎯 Review Instructions
Read code. Test locally with netcat or similar.