Skip to content

Add step size to disk monitor #1655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 20, 2021
Merged

Conversation

lava
Copy link
Member

@lava lava commented May 11, 2021

📔 Description

Add a "step size" setting to the disk monitor to only trigger re-checking of the disk size after deleting N partitions. Useful for situations where computing the disk size is computationally expensive, e.g. on compressed filesystems.

📝 Checklist

  • All user-facing changes have changelog entries.
  • The changes are reflected on docs.tenzir.com/vast, if necessary.
  • The PR description contains instructions for the reviewer, if necessary.

🎯 Review Instructions

Copy link
Member

@dominiklohmann dominiklohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just have three small comments and this needs a changelog entry. Other than that this is ready to ship.

I tested this locally with very small partition sizes and a custom check binary that counts partition files. It works very well.

@dominiklohmann dominiklohmann removed their assignment May 18, 2021
@lava lava marked this pull request as ready for review May 20, 2021 10:48
@lava lava enabled auto-merge May 20, 2021 10:49
@lava lava disabled auto-merge May 20, 2021 11:01
@lava lava enabled auto-merge May 20, 2021 11:07
@lava lava merged commit d51b2fe into master May 20, 2021
@lava lava deleted the story/ch24291/disk-monitor-step-size branch May 20, 2021 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants